-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix OpenAPI alternatives not showing #3699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenAPI alternatives not showing #3699
Conversation
🦋 Changeset detectedLatest commit: 23e26ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes an issue where OpenAPI alternatives were not being displayed due to incorrect rendering priority. The main change reorders the conditional logic in the OpenAPISchema component to ensure alternatives are checked and rendered before properties.
- Reordered rendering logic to prioritize alternatives over properties
- Added a minor CSS adjustment for the disclosure trigger label positioning
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/react-openapi/src/OpenAPISchema.tsx | Moved the properties rendering logic after alternatives to fix display priority |
packages/gitbook/src/components/DocumentView/OpenAPI/style.css | Adjusted right positioning for the disclosure trigger label |
.changeset/unlucky-pumpkins-yawn.md | Added changeset documentation for the fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This pull request addresses an issue where OpenAPI alternatives were not displaying correctly. The main change involves reordering the rendering logic for OpenAPI schema properties to prioritize showing alternatives over properties, ensuring that alternatives are visible when present.