Skip to content

Conversation

gregberge
Copy link
Contributor

@gregberge gregberge commented Oct 7, 2025

disableTransitionOnChange is magic 🪄

Copy link

linear bot commented Oct 7, 2025

Copy link

changeset-bot bot commented Oct 7, 2025

⚠️ No Changeset found

Latest commit: b935ddf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the disableTransitionOnChange prop to the ThemeProvider component to prevent flashing during navigation between sections. It also includes an update to the next-themes package dependency.

  • Adds disableTransitionOnChange prop to ThemeProvider to eliminate theme transition flashing
  • Restructures JSX hierarchy to move ThemeProvider outside NuqsAdapter
  • Updates next-themes dependency from ^0.2.1 to ^0.4.6

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/gitbook/src/components/SiteLayout/SiteLayoutClientContexts.tsx Restructures component hierarchy and adds disableTransitionOnChange prop to ThemeProvider
packages/gitbook/package.json Updates next-themes dependency to version ^0.4.6

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

argos-ci bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 50 changed Oct 7, 2025, 9:33 AM
v2-cloudflare (Inspect) 👍 Changes approved 3 changed Oct 7, 2025, 9:36 AM
v2-vercel (Inspect) 👍 Changes approved 1 changed Oct 7, 2025, 9:35 AM

@gregberge gregberge enabled auto-merge (squash) October 7, 2025 09:51
@gregberge gregberge merged commit f70a2aa into main Oct 7, 2025
16 checks passed
@gregberge gregberge deleted the greg/rnd-7565-docs-flash-light-mode-when-navigating-between-sections branch October 7, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants