-
Notifications
You must be signed in to change notification settings - Fork 4k
Disable flashing when navigating between sections #3705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable flashing when navigating between sections #3705
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the disableTransitionOnChange
prop to the ThemeProvider component to prevent flashing during navigation between sections. It also includes an update to the next-themes package dependency.
- Adds
disableTransitionOnChange
prop to ThemeProvider to eliminate theme transition flashing - Restructures JSX hierarchy to move ThemeProvider outside NuqsAdapter
- Updates next-themes dependency from ^0.2.1 to ^0.4.6
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/gitbook/src/components/SiteLayout/SiteLayoutClientContexts.tsx | Restructures component hierarchy and adds disableTransitionOnChange prop to ThemeProvider |
packages/gitbook/package.json | Updates next-themes dependency to version ^0.4.6 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
disableTransitionOnChange
is magic 🪄