Skip to content

fix: Actually avoid serde as dependency, when the serde feature is off #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

bpeetz
Copy link
Contributor

@bpeetz bpeetz commented May 30, 2025

faster-hex has serde as default dependency, and was not marked with default-features = false.

I found this while using gix with it's default features turned off.

`faster-hex` has serde as default dependency, and was not marked with
`default-features = false`.
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, a great catch!

I should remember to always check for default features, and maybe even protect from future added defaults by always disabling default features in third-party dependencies.

@Byron Byron merged commit 874cc38 into GitoxideLabs:main May 30, 2025
23 checks passed
@bpeetz
Copy link
Contributor Author

bpeetz commented May 30, 2025

Thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants