feat: ability to change the fetch url of a remote #2173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remote has a couple of "builder" methods to change is fields, e.g. `push_url` for setting the push url. A builder method for changing the fetch url of a remote was missing. This makes it impossible to fully replicate the functionality of `git remote set-url`.
Byron
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Thanks a lot for contributing!
Having API symmetry is certainly a good trait to have. Probably I avoided having these to avoid confusion with the Repository::remote_at*() methods which do the same, but I added a note that ideally these are used instead.
To me these kinds of API are still unsolved, as in theory one would either want to have free access to the fields (something I prefer), or one has to provide both builders and setters for everything which is cumbersome.
It's certainly possible to find more instances where certain methods are missing even though one would expect them to be there.
|
Yeah, there's no silver bullet for the APIs. Thanks for merging this! 🫶 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remote has a couple of "builder" methods to change is fields, e.g.
push_urlfor setting the push url.A builder method for changing the fetch url of a remote was missing. This makes it impossible to fully replicate the functionality of
git remote set-url(e.g. look at the lengths I'm trying to workaround this (imperfectly) in a PR to replicategit remote set-url --push) injj: https://github.com/metlos/jj/blob/8ec7cd1f68a5279e6aff2faea248a4978d46d17a/lib/src/git.rs#L2024)