Implement std::fmt::Display
for FullNameRef
, PartialName
, and PartialNameRef
#2196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the missing
std::fmt::Display
trait for the reference name types ingix-ref
, completing the Display implementation coverage for all reference name types.Changes
FullNameRef
: Added Display implementation togix-ref/src/fullname.rs
PartialName
: Added Display implementation togix-ref/src/name.rs
PartialNameRef
: Added Display implementation togix-ref/src/name.rs
All implementations follow the same pattern as the existing
FullName
Display implementation by delegating to the underlyingBString
/BStr
Display implementation.Usage
With these changes, users can now format all reference name types consistently:
Testing
Added comprehensive tests covering all four reference name types with various reference patterns (branches, remotes, tags, HEAD, etc.) to ensure the Display implementations work correctly with both
format!()
and.to_string()
.All existing tests continue to pass, confirming no regressions were introduced.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.