Skip to content

Conversation

Byron
Copy link
Member

@Byron Byron commented Apr 18, 2022

If a commit has multiple tags, describe should return the most recent one.

Commands to reproduce:

❯ git tag v2 -m "Testing tags v2"
❯ git tag v0 -m "Testing tags v0" "HEAD~1"
❯ git tag v1 -m "Testing tags v1"
❯ git describe
v1
❯ gix repository commit describe
v2

Byron added 2 commits April 18, 2022 13:00
Additionally ergonomics have been improved as the iterator is now
`Copy`, similarly to the other iterators.
@Byron
Copy link
Member

Byron commented Apr 18, 2022

Sorry, @davidkna, I wasn't aware that changing an issue into a PR via the Github API changes ownership as undesired side-effect. I won't be doing this again and instead just link a new PR to the original issue.

@Byron Byron closed this in a1680b4 Apr 18, 2022
@Byron Byron merged commit 56d7ad7 into main Apr 18, 2022
@davidkna
Copy link
Contributor Author

@Byron I don't mind. Thank you for fixing this!

@Byron Byron deleted the fix-describe branch April 22, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants