This repository has been archived by the owner on Apr 21, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #38.
One problem was the
a [href "#"] [onClick ...]
... thehref
essentially contradicts what theonClick
wants to do. One would either have to use the correcthref
(and have noonClick
), or (better) have nohref
and just rely on theonClick
.I'm presuming the purpose of the
href "#"
is to ensure that the cursor changes to a pointer, so I put that in manually.I suppose we do lose the ":visited" styling this way (which we could get by using the correct
href
) -- in cases where distinct styling for ":visited" was critical, one could use the correcthref
and leave off theonClick
.The other issue relates to how to handle "default" URLs (that is, what page do we want to show for an empty hash). I've made some changes here that seem to improve that. I should work on this a bit and see if I can make it nicer in
elm-route-url
-- there is some interaction here between whatelm-lang/navigation
does and and whatelm-route-url
does and whatevancz/url-parser
does, and I'm not absolutely sure what the best approach is.