Testing WebDriverIO #43

ordavidil · 2017-02-12T14:23:18Z

amitaibu · 2017-02-12T21:59:17Z

ci-scripts/docker_files/preparing_client.sh

+
+apt-get install openjdk-7-jre-headless -y
+
+# Install Selenium.


selenium isn't needed for the tests, as they run via Chrome driver directly.

amitaibu · 2017-02-17T13:57:55Z

@ordavidil maybe instead of trying to install Chrome, you can use another docker container for this. See, which is using https://github.com/elgalu/docker-selenium. Otherwise, maybe that repo can at least act as a source to see how do it.

ordavidil · 2017-02-21T12:53:09Z

@ItamarGronich
Check this PR ^^

also you might want to check this one:
https://hub.docker.com/r/casperlai/docker-webdriverio/

AronNovak · 2017-02-23T13:32:09Z

@ordavidil It seems i can start it now, not sure if i will have a clean timeslot now, but just took a look.
So

 > Test WebDriverIO. 
[07:31:28] Using gulpfile /var/www/html/Server/client/gulpfile.js

ERROR: Couldn't initialise service "phantomjs".
Error: Cannot find module 'wdio-phantomjs-service'

...
   at process.<anonymous> (/var/www/html/Server/client/node_modules/webdriverio/build/lib/runner.js:749:22)
...
The command "$TRAVIS_BUILD_DIR/ci-scripts/test_server.sh" exited with 1.

What's on those lines from the build output, it sums up the issue nicely, right?

amitaibu · 2017-02-23T13:35:48Z

when chrome driver isn't running, it's falling back to phantomjs

AronNovak · 2017-02-23T13:58:43Z

Ok, thanks. Right now I try to see the very same fail at localhost:

 aaron   29-webdriverio-travis  ⋯  drupal-elm-starter  ci-scripts  docker_files  docker build -t "gizra:drupal-elm-starter" .
Sending build context to Docker daemon 14.85 kB
Step 0 : FROM gizra/drupal-lamp
 ---> 0a63954adc6f
Step 1 : ADD $TRAVIS_BUILD_DIR /var/www/html/Server
 ---> Using cache
 ---> 5b663a5c8236
Step 2 : WORKDIR /var/www/html/Server
 ---> Using cache
 ---> 812c0137bbf2
Step 3 : RUN chmod +x /var/www/html/Server/ci-scripts/docker_files/run.sh
 ---> Running in 544d5945b694
chmod: cannot access '/var/www/html/Server/ci-scripts/docker_files/run.sh': No such file or directory
The command '/bin/sh -c chmod +x /var/www/html/Server/ci-scripts/docker_files/run.sh' returned a non-zero code: 1

But it fails to build an image from the Dockerfile. Any hints? Thanks!

ordavidil · 2017-02-23T14:21:04Z

@AronNovak
what's the command you invoke in order to build the image?
and what's the command to run the container ?

AronNovak · 2017-02-23T14:22:12Z

I am at the point just to build the image, the command is: docker build -t "gizra:drupal-elm-starter" .
And i am in /home/aaron/gizra/drupal-elm-starter/ci-scripts/docker_files

ordavidil · 2017-02-23T14:25:27Z

Build the image:

docker build -t server -f ci-scripts/docker_files/Dockerfile .

Run the container:

docker run -it -p 8080:80 -e BUILD_WEBDRIVERIO=1 server

Run from the ROOT directory.

amitaibu · 2017-02-23T14:27:03Z

@AronNovak ^^ I think worth adding this info to the README under /ci-scripts

amitaibu · 2017-03-06T14:50:39Z

Worth contacting them to ask

AronNovak · 2017-03-06T14:59:31Z

@amitaibu @ordavidil Thanks for the feedback, I go ahead and I contact Travis about this issue and going to make the other two builds pass in the meantime of course..

…ent's, coder style warning fix.

AronNovak · 2017-03-06T15:32:13Z

Mail sent to Travis support, and other 2 tests were fixed:

On hold until received answer about the cross-container communication issue.

amitaibu · 2017-03-06T15:56:54Z

On hold until received answer about the cross-container communication issue.

They probably won't know how to answer. The support should be about how to allow us to debug a Travis instance (they have a way of letting you to ssh into the box)

AronNovak · 2017-03-06T15:59:20Z

Indeed, thanks for the notice, then I just did a follow-up on the thread mentioning that debugging (SSH, etc) would be sufficient help for us.

AronNovak · 2017-03-07T05:29:12Z

The support was swift, they enabled us to debug the build with SSH, so hopefully we will be able to soon solve this, I tested the SSH access, it works like a charm, the only limitation is that only one SSH session is enabled, but there are workarounds for that, for instance tmux, as i will need to issue docker commands while docker-compose up is running.

…IO test [skip ci]

AronNovak · 2017-03-07T08:03:33Z

We're one step further. one of the tests passes at Travis server:

There was a timing issue, at localhost, everything completed faster, at Travis, as we send gulp to the background, we started to test even before the application was up and running via gulp.

amitaibu · 2017-03-07T08:07:28Z

nice!

Usually, on travis we gulp and then curl the url until we get a 200

amitaibu · 2017-03-07T08:08:03Z

https://github.com/Gizra/gizra.com/blob/e4a73f5f32f7cc10feec0252a86ff2b44c670be2/.travis.yml#L30

AronNovak · 2017-03-07T08:16:38Z

Tests are passing, I am doing some improvements like #43 (comment) and so on!

…skip ci]

…_client.sh already contains that [skip ci]

…container to test Behat.

…nning the container

…inherit from host shell

…/prepare_client.sh already contains that" This reverts commit 6c088c7.

AronNovak · 2017-03-07T09:08:47Z

I performed the tweaks I had in mind, any further feedback is highly appreciated!

amitaibu · 2017-03-07T09:58:45Z

🎉 It's green!

amitaibu · 2017-03-07T09:59:43Z

client/src/elm/Pages/Login/Update.elm

@@ -1,6 +1,7 @@
 module Pages.Login.Update exposing (fetchUserFromBackend, update)

 import Config.Model exposing (BackendUrl)
+import Http exposing (Error(BadStatus))


is this change related, or just need a re-roll with master?

It's coming from c244a19 , on my side, it's not related. It seems, at a certain point, the Elm app/test itself was modified for some reason, we might revert those commits, if not needed.

@rohanorton could you help us about the purpose of the Elm-related commits under this PR? Thank you!

They're originally from this PR: #51. It was to prevent error messages being shown on invalid session tokens.

amitaibu · 2017-03-07T12:29:28Z

Sorry, what I meant was that you had to git merge master into the branch. I've done so, and waiting for green to merge.

Amazing work folks!

amitaibu · 2017-03-07T12:43:15Z

client/wdio.conf.js

@@ -72,10 +72,10 @@ exports.config = {
    //
    // Set a base URL in order to shorten url command calls. If your url parameter starts
    // with "/", then the base url gets prepended.
-    baseUrl: 'http://localhost:3000',
+    baseUrl: 'http://server.local:3000',


@AronNovak oh, this was changed on the general client/wdio.conf.js. Please create a client/wdio.conf.travis.js and execute it instead, and revert the changes introduced here

ordavidil added 15 commits February 12, 2017 16:22

WIP: testing WebDriverIO

fadaeb5

Fixing ROOT_DIR inside the docker.

ca3c332

Install bower globally.

d54a850

Indicating sniffing standard.

70992cb

Echo standard between quotes ...

3e06355

Restructure the files.

5af7797

Do not build the regular client (since we build it inside the docker).

709bb65

Remove unnecessary condition.

4008709

Revert install_client.sh script.

5dc5132

Try to fix the current path.

5ac3918

Fixing the path.

e0bdc09

Trying to fix the bash var condition.

9666d59

Make sure BUILD_WEBDRIVERIO is being set before running the docker.

881db4d

WIP: fixing the server build.

0cb707e

Installing Chrome driver instead of firefox.

6f8d315

amitaibu reviewed Feb 12, 2017

View reviewed changes

ordavidil added 3 commits February 13, 2017 08:59

Removing selenuim.

e059059

Try to fix the variable passed to the docker.

e49354a

allow root for the bower.

4ec1d75

ordavidil assigned AronNovak Feb 22, 2017

documented local Docker execution

994800d

AronNovak added 2 commits March 6, 2017 16:04

hedley_migrate: drop constructor that does nothing in addition to par…

20c1fd6

…ent's, coder style warning fix.

test_server.sh: fix to set default value for webdriverio switch

32fab73

preparing_client.sh: wait for gulp completion before launching the WD…

d90f603

…IO test [skip ci]

wdio.conf.js: raise timeout to adapt to slower Travis environment

d7cc59e

AronNovak added 6 commits March 7, 2017 09:22

preparing_client.sh: simplify the code to wait for gulp compilation […

c306055

…skip ci]

preparing_client.sh: drop copying Elm localconfig, ci-scripts/prepare…

6c088c7

…_client.sh already contains that [skip ci]

test_server.sh: optimize the speed of execution, no need to selenium …

6abf182

…container to test Behat.

test_server.sh: set default value for env. variable anyways before ru…

1454af6

…nning the container

ci-scripts/test_server.sh: fix env variable passing, docker does not …

d6e3ef9

…inherit from host shell

Revert "preparing_client.sh: drop copying Elm localconfig, ci-scripts…

ab0e849

…/prepare_client.sh already contains that" This reverts commit 6c088c7.

AronNovak changed the title ~~WIP: testing WebDriverIO~~ Testing WebDriverIO Mar 7, 2017

amitaibu reviewed Mar 7, 2017

View reviewed changes

Merge branch 'master' into 29-webdriverio-travis

1bb53af

amitaibu merged commit b90aba6 into master Mar 7, 2017

amitaibu deleted the 29-webdriverio-travis branch March 7, 2017 12:41

amitaibu reviewed Mar 7, 2017

View reviewed changes

AronNovak mentioned this pull request Mar 7, 2017

fix the location of env-specific Travis WDIO configfile #55

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Testing WebDriverIO #43

Testing WebDriverIO #43

ordavidil commented Feb 12, 2017

amitaibu Feb 12, 2017

amitaibu commented Feb 17, 2017

ordavidil commented Feb 21, 2017 •

edited

Loading

AronNovak commented Feb 23, 2017

amitaibu commented Feb 23, 2017

AronNovak commented Feb 23, 2017

ordavidil commented Feb 23, 2017

AronNovak commented Feb 23, 2017

ordavidil commented Feb 23, 2017 •

edited

Loading

amitaibu commented Feb 23, 2017

amitaibu commented Mar 6, 2017

AronNovak commented Mar 6, 2017

AronNovak commented Mar 6, 2017

amitaibu commented Mar 6, 2017

AronNovak commented Mar 6, 2017

AronNovak commented Mar 7, 2017

AronNovak commented Mar 7, 2017

amitaibu commented Mar 7, 2017

amitaibu commented Mar 7, 2017

AronNovak commented Mar 7, 2017

AronNovak commented Mar 7, 2017

amitaibu commented Mar 7, 2017

amitaibu Mar 7, 2017

AronNovak Mar 7, 2017

AronNovak Mar 7, 2017

rohanorton Mar 7, 2017 •

edited

Loading

amitaibu commented Mar 7, 2017

amitaibu Mar 7, 2017


		apt-get install openjdk-7-jre-headless -y

		# Install Selenium.

Testing WebDriverIO #43

Testing WebDriverIO #43

Conversation

ordavidil commented Feb 12, 2017

amitaibu Feb 12, 2017

Choose a reason for hiding this comment

amitaibu commented Feb 17, 2017

ordavidil commented Feb 21, 2017 • edited Loading

AronNovak commented Feb 23, 2017

amitaibu commented Feb 23, 2017

AronNovak commented Feb 23, 2017

ordavidil commented Feb 23, 2017

AronNovak commented Feb 23, 2017

ordavidil commented Feb 23, 2017 • edited Loading

amitaibu commented Feb 23, 2017

amitaibu commented Mar 6, 2017

AronNovak commented Mar 6, 2017

AronNovak commented Mar 6, 2017

amitaibu commented Mar 6, 2017

AronNovak commented Mar 6, 2017

AronNovak commented Mar 7, 2017

AronNovak commented Mar 7, 2017

amitaibu commented Mar 7, 2017

amitaibu commented Mar 7, 2017

AronNovak commented Mar 7, 2017

AronNovak commented Mar 7, 2017

amitaibu commented Mar 7, 2017

amitaibu Mar 7, 2017

Choose a reason for hiding this comment

AronNovak Mar 7, 2017

Choose a reason for hiding this comment

AronNovak Mar 7, 2017

Choose a reason for hiding this comment

rohanorton Mar 7, 2017 • edited Loading

Choose a reason for hiding this comment

amitaibu commented Mar 7, 2017

amitaibu Mar 7, 2017

Choose a reason for hiding this comment

ordavidil commented Feb 21, 2017 •

edited

Loading

ordavidil commented Feb 23, 2017 •

edited

Loading

rohanorton Mar 7, 2017 •

edited

Loading