This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 133
Node context negotiation fails #34
Labels
Comments
Yeah, lets revert |
kaaresl
added a commit
to kaaresl/og
that referenced
this issue
Feb 25, 2015
kaaresl
added a commit
to kaaresl/og
that referenced
this issue
Feb 26, 2015
…ernal function _og_context_get_menu_router_item()
kaaresl
added a commit
to kaaresl/og
that referenced
this issue
Mar 6, 2015
kaaresl
added a commit
to kaaresl/og
that referenced
this issue
Mar 6, 2015
…ernal function _og_context_get_menu_router_item()
kaaresl
added a commit
to kaaresl/og
that referenced
this issue
Mar 6, 2015
kaaresl
added a commit
to kaaresl/og
that referenced
this issue
Mar 6, 2015
kaaresl
added a commit
to kaaresl/og
that referenced
this issue
Mar 6, 2015
kaaresl
added a commit
to kaaresl/og
that referenced
this issue
Mar 6, 2015
kaaresl
added a commit
to kaaresl/og
that referenced
this issue
Mar 7, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Problem / Motivation
Issue #28 and commit 66d3b72 causes Node context negotiation to fail due to comparison between menu router path (pattern) and path instance:
For nodes this result in comparison between e.g.
node/1107
andnode/%
.Proposed resolution
One of:
menu_get_item()
may result in a new/nested call to og_context() due to menu router item object loading and translation. But one cannot compare a menu item path with a live path due to the above comparison failure, so you have to retrieve the menu router item from the current live path somehow. One solution is to implement a truncated version ofmenu_get_item()
that halts processing the router item before item translation and object loading. It's only used to compare string. Leave it to the negotiation implementations to further check access control.The text was updated successfully, but these errors were encountered: