Mixpanel analytics

[sirpy]

Description

• Add support for mixpanel
• modify app_open event
• add some user props for analytics

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
good-dapp	❌ Failed (Inspect)			Feb 12, 2023 at 8:28AM (UTC)
goodid	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 12, 2023 at 8:28AM (UTC)

[johnsmith-gooddollar]

1. small formatting
2. getting source / platform repeats in analytics and routerselector. I've model it to utility method could be re-used from both places. Also I've added check for successful amplitude initialisation before call for identify
3. amplitude and mix panel initialisations are looking somilar but not exact. I've aligned them, moving some extra stuff like logging and updating isAmp/MixpanelEnabled flags inside init methods to make initAnalytics() shorter
4. mix panel native wrapper won't work. as you're using the MixPanelAPI object itself (not the result init() method returns) And this object exposes just init(), so other method calls will fail. To align interfaces I've generally using Proxy (see AsyncStorage or other analytics api wrappers), so I reworked it that way. Also mutating prototypes of some base classes is an anti-patter, should be avoided
5. to avoid recall with ...args in a every method, I've also used Proxy inside Mixpanel's web api wrapper. Also it's possible to use a simple methods names map instead of declaring each method
6. some bug fixes from local testing. there was one more misalignment - native init() is async while web's - no. I've wrapped it inside async method

[sirpy]

NO REFACTORING
REVERT

[johnsmith-gooddollar]

@sirpy reverted

What I've left:

1. DRY issue fix - getting user source / platform moved to util fn
2. native wrapper fix, no prototype override
3. if success check on amplitude init
4. I've added param names to wrappers instead of ...params

need to re-review after revert