Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the names and descriptions of the feature types #4106

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

jyasskin
Copy link
Collaborator

@jyasskin jyasskin commented Jul 11, 2024

... to try to direct developers to the right one more often.

Changes
image
to
image

The discussion on blink-api-owners-discuss was generally positive, with some future improvements identified.

This does not change the
image
description in features' metadata sections because that string comes from

BLINK_FAST_TRACK_PROCESS = Process(
'Existing feature implementation',
'Description of blink fast track process', # Not used yet.
'When to use it', # Not used yet.
BLINK_FAST_TRACK_STAGES)
instead of the JS form definition.

Copy link
Collaborator

@DanielRyanSmith DanielRyanSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a change like this, while not a complete solution, will go far in avoiding wrong choices for feature type in the future.

@jyasskin
Copy link
Collaborator Author

The discussion on blink-api-owners-discuss suggested a couple changes, which I've adopted. The "New or changed feature" vs "catches up" descriptions could do more to explain exactly what's different between those options, but I don't have time to figure that out before going on vacation, so I'm going to merge this for the incremental improvement, and come back to it in another PR.

@jyasskin jyasskin merged commit 7fb85a5 into GoogleChrome:main Jul 15, 2024
7 checks passed
@jyasskin jyasskin deleted the clarify-feature-types branch July 15, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants