-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(treemap): add GA snippet for new property #12481
Conversation
@@ -87,17 +87,14 @@ | |||
|
|||
<script src="src/bundled.js"></script> | |||
|
|||
<!-- Google Analytics --> | |||
<!-- Global site tag (gtag.js) - Google Analytics --> | |||
<script async src="https://www.googletagmanager.com/gtag/js?id=G-16X003MB7V"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢
|
||
ga('create', 'UA-85519014-2', 'auto'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just change the property descriptor? analytics still documents this approach and I'd hate to not follow our own aspirational advice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, and the different prefix in the identifier makes me think twice about doing that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well this majorly sucks https://support.google.com/analytics/answer/9539598?hl=en 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so GA 4 isn't as bad as I thought
good news: stopped doing the double script hop, so gtag is the only script loaded to fire GA events
bad news: the script is 140% larger and increases TBT 385% more (granted GA only contributes ~5ms with the original so quintupling only gives you ~25ms, but hey I'm still a little salty 😉 )
|
||
ga('create', 'UA-85519014-2', 'auto'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well this majorly sucks https://support.google.com/analytics/answer/9539598?hl=en 😭
Just tracking page views for now.
ref #11254