Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(treemap): upgrade to 3.2.0 for keyboard navigation #12488

Merged
merged 1 commit into from
May 17, 2021
Merged

misc(treemap): upgrade to 3.2.0 for keyboard navigation #12488

merged 1 commit into from
May 17, 2021

Conversation

connorjclark
Copy link
Collaborator

ref #11254

@connorjclark connorjclark requested a review from a team as a code owner May 14, 2021 23:14
@connorjclark connorjclark requested review from patrickhulce and removed request for a team May 14, 2021 23:14
@google-cla google-cla bot added the cla: yes label May 14, 2021
patrickhulce
patrickhulce approved these changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! having right/left wrap around might be nice add in the future (or maybe not? 😆 I'd love to learn what a11y best practice is for something like that), but this was super smooth 👍

@connorjclark connorjclark merged commit c12959f into master May 17, 2021
@connorjclark connorjclark deleted the treemap-kbd branch May 17, 2021 17:46
@connorjclark connorjclark mentioned this pull request May 17, 2021
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees

@patrickhulce patrickhulce

Labels
cla: yes waiting4committer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @patrickhulce @devtools-bot