report(performance): use metric savings for metric filter #15540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Oct 16, 2023
| @@ -338,7 +372,7 @@ export class PerformanceCategoryRenderer extends CategoryRenderer { | |||
|
|
|||
| const labelEl = this.dom.createChildOf(metricFilterEl, 'label', 'lh-metricfilter__label'); | |||
| labelEl.htmlFor = elemId; | |||
| labelEl.title = metric.result?.title; | |||
| labelEl.title = 'result' in metric ? metric.result.title : ''; | |||
There was a problem hiding this comment.
This fixes a bug where the title of the "All" filter button is "undefined"
adamraine
changed the title
adamraine
commented
Oct 19, 2023
| @@ -197,6 +197,8 @@ declare module Result { | |||
|
|
|||
| /** Gather mode used to collect artifacts. */ | |||
| type GatherMode = 'navigation'|'timespan'|'snapshot'; | |||
|
|
|||
| type MetricAcronym = 'FCP' | 'LCP' | 'TBT' | 'CLS' | 'INP' | 'SI' | 'TTI' | 'FMP'; | |||
There was a problem hiding this comment.
|
ping @connorjclark |
connorjclark
reviewed
Jan 3, 2024
connorjclark
reviewed
Jan 3, 2024
connorjclark
reviewed
Jan 3, 2024
| */ | ||
| renderAudit(audit) { | ||
| const component = this.dom.createComponent('audit'); | ||
| return this.populateAuditValues(audit, component); | ||
| return /** @type {HTMLElement} */ (this.populateAuditValues(audit, component)); |
There was a problem hiding this comment.
which part required this change to return type?
There was a problem hiding this comment.
hidden is not a property on Element but it is on HTMLElement
connorjclark
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15445 (comment)
Metric filter was still using
relevantAuditswhich is just a manually curated list that we haven't touched in a while. This PR usesmetricSavingsinstead to determine filter applicability and sorts the audits on the filtered metric.