core: create separate product savings type #15726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
requested review from
connorjclark and
brendankenny
and removed request for
a team
adamraine
commented
Jan 4, 2024
| @@ -360,7 +360,7 @@ export class PerformanceCategoryRenderer extends CategoryRenderer { | |||
| textEl.textContent = Globals.strings.showRelevantAudits; | |||
|
|
|||
| const filterChoices = [ | |||
| /** @type {const} */ ({acronym: 'All'}), | |||
| /** @type {const} */ ({acronym: 'All', id: 'All'}), | |||
There was a problem hiding this comment.
This was necessary because of a type error on L380. Just seemed easier to do this than figure out how to narrow the type down there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #15721 (comment). This is really just reshuffling the types so that metrics can define their acronym to be any string, but the audit product still needs to be one of FCP/LCP/TBT/CLS/INP.
Follow up to #15721 and #15540