Nuke EIL percentiles from reports #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
force-pushed
the
nukeEILpercentiles
branch
2 times, most recently
from
63f1ad7
to
e03a2f3
Compare
paulirish
force-pushed
the
nukeEILpercentiles
branch
from
e03a2f3
to
ccae965
Compare
brendankenny
approved these changes
Nov 1, 2016
| @@ -35,6 +35,9 @@ class EstimatedInputLatency extends Audit { | |||
| name: 'estimated-input-latency', | |||
| description: 'Estimated Input Latency', | |||
| optimalValue: SCORING_POINT_OF_DIMINISHING_RETURNS.toLocaleString() + 'ms', | |||
| helpText: 'Primarily a measure of the main thread\'s activity. ' + | |||
| 'There is a 90% probabililty a user would encounter of this amount or less. ' + | |||
There was a problem hiding this comment.
"There is a 90% probabililty a user would encounter input latency of this amount or less"?
paulirish
force-pushed
the
nukeEILpercentiles
branch
from
ccae965
to
48f44c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In their current form, they don't add much.
I'd like to show the EIL/EQT distribution at some point, but for now, it's better to clean up the output: