Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI #875

Merged
merged 72 commits into from
Dec 9, 2020
Merged

Add CLI #875

merged 72 commits into from
Dec 9, 2020

Conversation

surma
Copy link
Collaborator

@surma surma commented Dec 5, 2020

This PR adds the CLI to the main repository.

One heads up: The CLI currently doesn’t support encoding or decoding JPEG. I needed to add the MozJPEG decoder, as we can rely on browsers for decoding JPEG for the web. That needs a bit of re-jigging of the folder structure so I want to do that in a separate follow-up PR.

cli/src/codecs.js Outdated Show resolved Hide resolved
cli/src/image_data.js Outdated Show resolved Hide resolved
Co-authored-by: Ingvar Stepanyan <me@rreverser.com>
cli/src/codecs.js Outdated Show resolved Hide resolved
surma and others added 2 commits December 8, 2020 18:24
Co-authored-by: Ingvar Stepanyan <me@rreverser.com>
Co-authored-by: Ingvar Stepanyan <me@rreverser.com>
@google-cla
Copy link

google-cla bot commented Dec 8, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

2 similar comments
@google-cla
Copy link

google-cla bot commented Dec 8, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Dec 8, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

codecs/png/src/lib.rs Outdated Show resolved Hide resolved
codecs/jxl/Makefile Outdated Show resolved Hide resolved
Co-authored-by: Ingvar Stepanyan <me@rreverser.com>
cli/src/codecs.js Outdated Show resolved Hide resolved
cli/src/codecs.js Outdated Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented Dec 8, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Dec 8, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Dec 8, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@developit
Copy link
Collaborator

@googlebot I consent.

cli/README.md Outdated Show resolved Hide resolved
cli/package.json Outdated Show resolved Hide resolved
@@ -0,0 +1,12 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidentally included?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so!

cli/src/image_data.js Outdated Show resolved Hide resolved
@surma surma merged commit a19e97b into dev Dec 9, 2020
@surma surma deleted the visdf branch December 9, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants