-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StatefulSet scaling on GKE Autopilot #1085
Conversation
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
76313f6
to
bfc11b6
Compare
2bd3c78
to
b2c3bea
Compare
@@ -0,0 +1,98 @@ | |||
# Copyright 2022 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file not with the other manifests in the kubernetes-manifests/ directory you created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use kubernetes-manifests/
directory to deploy only Bank of Anthos app. The load generator is a separate entity in this example and the file should be modified before applying (see README)
@@ -0,0 +1,136 @@ | |||
# Copyright 2019 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give me a quick run-down of the diff between the root kubernetes-manifests/ and this new directory with copies?
(Note that Kustomize is coming in this repo in the next month or two, which should greatly simplify these duplicates -- but in the meantime duplicates are okay)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main change is related to resources limits and requests. Because this example should be run on GKE Autopilot I want to get rid of annoying warning message when kubectl apply -f
command runs
b2c3bea
to
43fc61f
Compare
@bourgeoisor ready to review. I have added answers to your comments and changed/renamed the dir structure. |
0d22d11
to
2be6188
Compare
Staging: http://34.171.27.57 |
@TheRealSpaceShip looks great so far! Could you:
|
- Removed ledger-db sts - Connection parameters as secret - Reconfigure deployments to use secret - Increased total connections number for PostgreSQL
- Rename of directory - Shorten README file
9acdfd0
to
dd7adca
Compare
Lines that start with # [START or # [END
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* StatefulSet scaling on GKE Autopilot * Fix CI checks * Apply suggestions from code review * Update readmes * Small improvements in kubernetes manifests * No need to disable managed prometheus in GKE * Usage single postgres instance - Removed ledger-db sts - Connection parameters as secret - Reconfigure deployments to use secret - Increased total connections number for PostgreSQL * Graceful shutdown for scaling services * Min 5 replicas for stateless services * Rename gke-autopilot directory to postgres-hpa - Rename of directory - Shorten README file * Fallback to previous timeout default value * Remove all region tags Lines that start with # [START or # [END
This PR adds to the extra directory a new setup of deployment of the Bank of Anthos Sample Application on GKE Autopilot with examples of autoscaling of StatefulSet and Stateless Kubernetes workloads with HPA objects based on standard and external metrics.
Change Summary
frontend
,userservice
,contacts
, and PostgreSQL StatefulSet