Early access build #235
Merged
Early access build #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved this by returning a boolean. |
nikklassen
suggested changes
Apr 27, 2020
...t/src/main/java/com/google/cloud/healthcare/fdamystudies/service/UserSupportServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/google/cloud/healthcare/fdamystudies/controller/UserSupportController.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/google/cloud/healthcare/fdamystudies/controller/UserSupportController.java
Show resolved
Hide resolved
...t/src/main/java/com/google/cloud/healthcare/fdamystudies/service/UserSupportServiceImpl.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/com/google/cloud/healthcare/fdamystudies/service/UserSupportServiceImpl.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/com/google/cloud/healthcare/fdamystudies/service/UserSupportServiceImpl.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/com/google/cloud/healthcare/fdamystudies/service/UserSupportServiceImpl.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/com/google/cloud/healthcare/fdamystudies/service/UserSupportServiceImpl.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/com/google/cloud/healthcare/fdamystudies/service/UserSupportServiceImpl.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/com/google/cloud/healthcare/fdamystudies/service/UserSupportServiceImpl.java
Outdated
Show resolved
Hide resolved
|
Please use more informative titles for your PRs. I would like to have a short desccription of the fix from the title. You can provide additional information in the description, but that should not just be a link to the issue. Ideally I can review the PR just from here, without having to refer back to the issue. |
nikklassen
suggested changes
Apr 27, 2020
...n/java/com/google/cloud/healthcare/fdamystudies/config/ApplicationPropertyConfiguration.java
Outdated
Show resolved
Hide resolved
...n/java/com/google/cloud/healthcare/fdamystudies/config/ApplicationPropertyConfiguration.java
Outdated
Show resolved
Hide resolved
… provided [ # 231]
nikklassen
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains bug # 231 fixes.
Note : Please replace feedback.email and contactus.email property's dummy value in appConfigurations.properties with the actual value.