Android: Feedback and contact us moved to registration server and pdf issue for unsupported characters fixed #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.Issue in pdf for unsupported character fixed 3.Study filter screen UI fixed
zohrehj
approved these changes
Apr 27, 2020
| doc, | ||
| assetManager.open("com/tom_roush/pdfbox/resources/ttf/LiberationSans-Regular.ttf")); | ||
| } catch (Exception e) { | ||
| font = PDType1Font.HELVETICA; |
There was a problem hiding this comment.
move this to where font is defined as an initial value.
| } | ||
| } | ||
|
|
||
| private StringBuffer replaceUnsupportedCharacter(String text) { |
There was a problem hiding this comment.
method name is misleading, since if the character is encodable it will not be replaced.
Should be called something like sanitizeCharacter instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Feedback and contactUs moved from wcp to registration server
2.Issue in pdf for unsupported character fixed
3.Study filter screen UI fixed
Note: #235 PR also needs to be merge along this build as it has the server side changes.