Skip to content

chore: add conformance test coverage for typed function signature #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

chore: add conformance test coverage for typed function signature #254

merged 1 commit into from
Jul 12, 2023

Conversation

garethgeorge
Copy link
Contributor

No description provided.

@garethgeorge garethgeorge force-pushed the garethgeorge/typed branch 2 times, most recently from 1679abe to b1d4054 Compare June 26, 2023 23:39
@garethgeorge
Copy link
Contributor Author

Conformance tests passing.

KaylaNguyen
KaylaNguyen approved these changes Jun 27, 2023
View reviewed changes
@kenneth-rosario kenneth-rosario mentioned this pull request Jul 6, 2023
Closed
@kenneth-rosario
Copy link

nit(unrelated to your change): Can you update https://github.com/GoogleCloudPlatform/functions-framework-python/pull/254/files#diff-e5ed24bc2f5084a1664419e35473c15466f87e7552ef1fad4d13cdde0eaed400R2 to only do push when it is on branch master? It seems like it is being duplicated during pull requests.
image

@garethgeorge garethgeorge force-pushed the garethgeorge/typed branch 2 times, most recently from 6c5d3c5 to 00a2cc6 Compare July 12, 2023 19:19
@garethgeorge
Copy link
Contributor Author

@kenneth-rosario done, added a branch selector to the push trigger for our ci runs.

@garethgeorge garethgeorge merged commit 854509a into master Jul 12, 2023
@garethgeorge garethgeorge deleted the garethgeorge/typed branch July 12, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@KaylaNguyen KaylaNguyen KaylaNguyen approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@KaylaNguyen KaylaNguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garethgeorge @kenneth-rosario @KaylaNguyen