Skip to content

fix: set default log level for asgi logger to WARNING to match default python behavior #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

fix: set default log level for asgi logger to WARNING to match default python behavior #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0b34ad
fix: set default log level for asgi logger to WARNING to match defaul…
taeold Jun 18, 2025
574a160
fix: fix broken test.
taeold Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/functions_framework/aio/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def _configure_app_execution_id_logging():
"stream": "ext://functions_framework.execution_id.logging_stream",
},
},
"root": {"level": "INFO", "handlers": ["asgi"]},
"root": {"level": "WARNING", "handlers": ["asgi"]},
}
)

Expand Down
2 changes: 1 addition & 1 deletion tests/test_functions/execution_id/async_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def sync_function_in_async_context(request):
def sync_cloudevent_with_context(cloud_event):
context = execution_id._get_current_context()
if context:
logger.info(f"Execution ID in sync CloudEvent: {context.execution_id}")
logger.warning(f"Execution ID in sync CloudEvent: {context.execution_id}")
else:
logger.error("No execution context in sync CloudEvent function!")

Expand Down
Loading