Skip to content

Add language-specific alias #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2020
Merged

Add language-specific alias #93

merged 3 commits into from
Oct 21, 2020

Conversation

di
Copy link
Member

@di di commented Oct 9, 2020

Fixes #92.

@google-cla google-cla bot added the cla: yes label Oct 9, 2020
@di di requested a review from asriniva October 9, 2020 06:15
@ace-n
Copy link

ace-n commented Oct 9, 2020

Nit: be sure to document this in the README as well.

@di
Copy link
Member Author

di commented Oct 13, 2020

@ace-n Are you saying we should replace every example invocation of functions-framework with functions-framework-python? I'm not sure we should do that. Or are you saying we should document that the alias is available?

@grant
Copy link
Contributor

grant commented Oct 13, 2020

I think he's just suggesting the latter, putting a note in the README that functions-framework-python also works.

Like here:

https://github.com/GoogleCloudPlatform/functions-framework-python#quickstarts

@di di merged commit 2b07aa9 into master Oct 21, 2020
@di di deleted the fix/92 branch October 21, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@asriniva asriniva asriniva approved these changes

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binaries should have language-specific alias
4 participants
@di @ace-n @grant @asriniva