Fix gcp-repo/metadata.p2.inf so that category is published in normal Maven builds#2043
Merged
briandealwis merged 1 commit intomasterfrom Jun 12, 2017
Merged
Fix gcp-repo/metadata.p2.inf so that category is published in normal Maven builds#2043briandealwis merged 1 commit intomasterfrom
briandealwis merged 1 commit intomasterfrom
Conversation
elharo
approved these changes
Jun 9, 2017
Contributor
|
Can you update the first step of the release instructions too? |
Codecov Report
@@ Coverage Diff @@
## master #2043 +/- ##
=========================================
Coverage 66.05% 66.05%
Complexity 1868 1868
=========================================
Files 322 322
Lines 12542 12542
Branches 1142 1142
=========================================
Hits 8284 8284
Misses 3833 3833
Partials 425 425Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CT4E category doesn't appear in the
gcp-repop2 repository when built from Maven. It does appear in our release builds as we explicitly re-publish artifacts as part of the release.This fixes our
metadata.p2.infto specify an exact range to pull in the category definition. It also changes some naming to distinguish between the category IU and the capabilities:$version$to use the version of the.product: no need to change the.p2.inffile for releases.definitionto the capability name, used to pull in the category IU from the product IU, to avoid confusion with the actual category IU. This capability is required as Tycho'sassemble-repositoryplugin only traverses the modules actually defined in this project, and it doesn't track the additional IUs defined in the.p2.inf.(
assemble-repository's docs](https://www.eclipse.org/tycho/sitedocs/tycho-p2/tycho-p2-repository-plugin/assemble-repository-mojo.html) note that it only follows IUs that are included, andIdentified as part of #2027