Skip to content

Fix gcp-repo/metadata.p2.inf so that category is published in normal Maven builds#2043

Merged
briandealwis merged 1 commit intomasterfrom
i2027-p2inf
Jun 12, 2017
Merged

Fix gcp-repo/metadata.p2.inf so that category is published in normal Maven builds#2043
briandealwis merged 1 commit intomasterfrom
i2027-p2inf

Conversation

@briandealwis
Copy link
Copy Markdown
Member

Our CT4E category doesn't appear in the gcp-repo p2 repository when built from Maven. It does appear in our release builds as we explicitly re-publish artifacts as part of the release.

This fixes our metadata.p2.inf to specify an exact range to pull in the category definition. It also changes some naming to distinguish between the category IU and the capabilities:

  • Use $version$ to use the version of the .product: no need to change the .p2.inf file for releases
  • Append .definition to the capability name, used to pull in the category IU from the product IU, to avoid confusion with the actual category IU. This capability is required as Tycho's assemble-repository plugin only traverses the modules actually defined in this project, and it doesn't track the additional IUs defined in the .p2.inf.
  • Change the category capability to always be version 1.0.0
  • Change the requirement to be an exact version

(assemble-repository's docs](https://www.eclipse.org/tycho/sitedocs/tycho-p2/tycho-p2-repository-plugin/assemble-repository-mojo.html) note that it only follows IUs that are included, and

Dependencies with a strict version range, i.e. a range which only matches exactly one version of an artifact, are also considered as inclusions.
And perhaps the [1.0.0,1.2.0] range is considered open-ended, vs the [1.0.0,1.0.0] which is an exact specification.

Identified as part of #2027

@chanseokoh
Copy link
Copy Markdown
Contributor

chanseokoh commented Jun 9, 2017

Can you update the first step of the release instructions too?

https://github.com/GoogleCloudPlatform/google-cloud-eclipse/wiki/Cloud-Tools-for-Eclipse-Release-Instructions

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 9, 2017

Codecov Report

Merging #2043 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2043   +/-   ##
=========================================
  Coverage     66.05%   66.05%           
  Complexity     1868     1868           
=========================================
  Files           322      322           
  Lines         12542    12542           
  Branches       1142     1142           
=========================================
  Hits           8284     8284           
  Misses         3833     3833           
  Partials        425      425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d37c1ca...1e16277. Read the comment docs.

@briandealwis briandealwis merged commit 5963fbe into master Jun 12, 2017
@briandealwis briandealwis deleted the i2027-p2inf branch June 12, 2017 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants