Skip to content

update kafka instructions for dealing with messages etc #10171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 30, 2025
Merged

update kafka instructions for dealing with messages etc #10171

merged 6 commits into from
Sep 30, 2025

Conversation

derrickaw
Copy link
Contributor

Description

  1. Adds more information about sending Kafka messages and environment variables setup if required.
  2. Fixes url to kafka image location.

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: dataflow Issues related to the Dataflow API. labels Sep 15, 2025
@derrickaw derrickaw marked this pull request as ready for review September 15, 2025 14:55
@derrickaw derrickaw requested review from yoshi-approver and a team as code owners September 15, 2025 14:55
iennae
iennae reviewed Sep 19, 2025
View reviewed changes
dataflow/flex-templates/kafka_to_bigquery/README.md Outdated
### Sending messages to Kafka server
The Kafka server should be running at this point, but in its current state no
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: blending in context with instruction to ssh makes this a little difficult to parse.

iennae
iennae reviewed Sep 19, 2025
View reviewed changes
iennae
iennae reviewed Sep 19, 2025
View reviewed changes
dataflow/flex-templates/kafka_to_bigquery/README.md Outdated
# Note: If the project name has `:` in it that signifies a project within an
# organization (e.g. `example.com:project-id`), replace those with `/` so that
# the Kafa image can be found appropriately.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Kafa/Kafka

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done

iennae
iennae reviewed Sep 19, 2025
View reviewed changes
iennae
iennae approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of nits and some suggestions but not blocking.

@derrickaw derrickaw requested a review from iennae September 22, 2025 20:14
@iennae iennae merged commit de522ce into GoogleCloudPlatform:main Sep 30, 2025
7 checks passed
@derrickaw derrickaw deleted the kafkaToBigQueryUpdates branch October 6, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iennae iennae iennae approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

+1 more reviewer

@liferoad liferoad liferoad approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: dataflow Issues related to the Dataflow API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derrickaw @iennae @liferoad