-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(genai): add image generation samples (2) #10173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): add image generation samples (2) #10173
Conversation
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the generative AI capabilities by introducing a suite of new image generation samples for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a set of new image generation samples for the imagen-3.0-capability-001
model, complete with integration tests. The new samples demonstrate various features like subject/style/control references. The code is generally well-written, but I've identified a few areas for improvement. My feedback includes correcting a hardcoded GCS URI in a sample, fixing a typo in a constant name within the tests, and suggestions to improve code readability by simplifying string concatenations.
...i/snippets/src/main/java/genai/imagegeneration/ImageGenSubjectReferenceWithTextAndImage.java
Outdated
Show resolved
Hide resolved
genai/snippets/src/main/java/genai/imagegeneration/ImageGenRawReferenceWithTextAndImage.java
Show resolved
Hide resolved
...i/snippets/src/main/java/genai/imagegeneration/ImageGenSubjectReferenceWithTextAndImage.java
Show resolved
Hide resolved
genai/snippets/src/test/java/genai/imagegeneration/ImageGenerationIT.java
Outdated
Show resolved
Hide resolved
… variable name in tests
genai/snippets/src/main/java/genai/imagegeneration/ImageGenCannyCtrlTypeWithTextAndImage.java
Outdated
Show resolved
Hide resolved
genai/snippets/src/main/java/genai/imagegeneration/ImageGenCannyCtrlTypeWithTextAndImage.java
Show resolved
Hide resolved
@jdomingr - check and fix the test file conflict |
Description
Add new image generation samples using imagen-3.0-capability-001 model:
Checklist
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only