Skip to content

Conversation

jdomingr
Copy link
Contributor

@jdomingr jdomingr commented Oct 2, 2025

Description

Add new batch prediction samples and update SDK:

  • Create a batch prediction job with Google Cloud Storage
  • Create a batch prediction job with embedding model and Google Cloud Storage
  • Update SDK to v1.20.0

Checklist

  • I have followed Sample Format Guide
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved

@jdomingr jdomingr requested review from yoshi-approver and a team as code owners October 2, 2025 16:09
Copy link

snippet-bot bot commented Oct 2, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 2, 2025
Copy link
Contributor

Summary of Changes

Hello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the GenAI SDK samples by introducing new functionalities for batch predictions. It includes two distinct samples: one for general batch prediction using models like Gemini Flash with Google Cloud Storage, and another specifically for embedding models, also leveraging GCS. Concurrently, the underlying GenAI SDK has been upgraded to version 1.20.0 to support these new features and ensure up-to-date compatibility.

Highlights

  • SDK Update: The google-genai dependency in pom.xml was updated from version 1.15.0 to 1.20.0.
  • New Batch Prediction Sample (General): A new Java sample, BatchPredictionWithGcs.java, was added to demonstrate creating a batch prediction job with a general model (e.g., gemini-2.5-flash) using Google Cloud Storage for input and output.
  • New Batch Prediction Sample (Embeddings): A new Java sample, BatchPredictionEmbeddingsWithGcs.java, was added specifically for creating a batch prediction job with an embedding model (e.g., text-embedding-005) and Google Cloud Storage.
  • Integration Tests: Corresponding integration tests (BatchPredictionIT.java) were added to validate the functionality of these new batch prediction samples, including mocking the client to verify job creation and state.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two new samples for batch prediction using the GenAI SDK (one for embeddings and one for generative models) and updates the SDK version. The new samples demonstrate how to create a batch job and poll for its completion. My review includes suggestions to improve code clarity and maintainability in the new samples by using more efficient data structures and avoiding magic numbers. I've also suggested an improvement to the integration tests to ensure the job polling logic is covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant