-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(genai): add batch prediction samples (1) and update GenAI SDK #10174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): add batch prediction samples (1) and update GenAI SDK #10174
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the GenAI SDK samples by introducing new functionalities for batch predictions. It includes two distinct samples: one for general batch prediction using models like Gemini Flash with Google Cloud Storage, and another specifically for embedding models, also leveraging GCS. Concurrently, the underlying GenAI SDK has been upgraded to version 1.20.0 to support these new features and ensure up-to-date compatibility. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two new samples for batch prediction using the GenAI SDK (one for embeddings and one for generative models) and updates the SDK version. The new samples demonstrate how to create a batch job and poll for its completion. My review includes suggestions to improve code clarity and maintainability in the new samples by using more efficient data structures and avoiding magic numbers. I've also suggested an improvement to the integration tests to ensure the job polling logic is covered.
Description
Add new batch prediction samples and update SDK:
Checklist
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only