Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The doc of GCP Instrumentation is out of date #738

Closed
cc4i opened this issue Feb 25, 2022 · 0 comments
Closed

The doc of GCP Instrumentation is out of date #738

cc4i opened this issue Feb 25, 2022 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.

Comments

@cc4i
Copy link
Contributor

cc4i commented Feb 25, 2022

Write down your inquiry

In the doc it instructs you to change value for specific environment, such as following:

  • name: DISABLE_TRACING
    value: "1"

Change to =>>>

  • name: DISABLE_TRACING
    value: "0"

However actually it should remove that environment from deployment manifest as per code, I suggest should change the doc to remove those environment variables instead.
cc4i added a commit to cc4i/microservices-demo that referenced this issue Feb 25, 2022
@cc4i
chore: update doc for instrument GoogleCloudPlatform#738
f1dfc8a
@cc4i cc4i mentioned this issue Feb 25, 2022
Merged
@xtineskim xtineskim added priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API. labels Feb 25, 2022
xtineskim added a commit that referenced this issue Feb 28, 2022
@cc4i @xtineskim
chore: update doc for instrument #738 (#739)
c7d2ca0 
Co-authored-by: Christine Kim <35876108+ckim328@users.noreply.github.com>
sitaramkm pushed a commit to sitaramkm/microservices-demo that referenced this issue Mar 27, 2022
@cc4i @xtineskim @sitaramkm
chore: update doc for instrument GoogleCloudPlatform#738 (GoogleCloud…
b5e4018 
…Platform#739)

Co-authored-by: Christine Kim <35876108+ckim328@users.noreply.github.com>
@snyk-bot snyk-bot mentioned this issue May 23, 2022
Open
@neatsun neatsun mentioned this issue May 23, 2022
Open
@amirkCA amirkCA mentioned this issue May 23, 2022
Open
@haseebH haseebH mentioned this issue May 23, 2022
Open
This was referenced May 23, 2022
Open
Open
Open
Open
Open
Open
Open
@nathanawmk nathanawmk mentioned this issue May 24, 2022
Open
@amirkCA amirkCA mentioned this issue May 24, 2022
Open
@haseebH haseebH mentioned this issue Jun 22, 2022
Open
@snyk-bot snyk-bot mentioned this issue Nov 10, 2022
Closed
@ekmixon ekmixon mentioned this issue May 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xtineskim @cc4i