Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LZ deployment Docs #129

Merged
merged 10 commits into from
Sep 21, 2022
Merged

Conversation

cartyc
Copy link
Contributor

@cartyc cartyc commented Sep 14, 2022

Updating documentation on LZ deployment.

This PR is aimed at improving the documentation around deploying with kpt and GitOps options. I am hoping to make things clearer as to what the different options do and when to use them.

Leaving this as a draft to collect more input and to test the new instructions around using OCI.

@cartyc cartyc added documentation Improvements or additions to documentation Landing Zone developer-experience labels Sep 14, 2022
@cartyc cartyc self-assigned this Sep 14, 2022
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

solutions/landing-zone/README.md Outdated Show resolved Hide resolved
solutions/landing-zone/README.md Show resolved Hide resolved
solutions/landing-zone/README.md Outdated Show resolved Hide resolved
@cartyc cartyc changed the title WIP: Update to LZ deployment Docs Update to LZ deployment Docs Sep 16, 2022
@cartyc cartyc marked this pull request as ready for review September 16, 2022 15:44
@fmichaelobrien
Copy link
Contributor

LGTM initial passes, Reviewing latest - more after 1630, will apply as much as possible

@fmichaelobrien
Copy link
Contributor

I have not had time to switch to the git commit version of the lz deployment to verify the scripts in the docs - still rounding out the kpt lz redeploy after our switch to na2. I can check the gitops/oci section later. Go ahead and merge 129

@fmichaelobrien
Copy link
Contributor

LGTM

@cartyc cartyc merged commit f156377 into GoogleCloudPlatform:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience documentation Improvements or additions to documentation Landing Zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants