Skip to content

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Jan 9, 2025

Description

Fixes b/347826199

Delete old region tag

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@OremGLG OremGLG requested review from a team as code owners January 9, 2025 17:10
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by OremGLG, aims to fix issue b/347826199 by deleting an outdated region tag from the gke_kubernetes_deployment_python section within the polls.yaml file. The changes are focused on removing obsolete code blocks.

Specifically, the following changes were made:

  • File: kubernetes_engine/django_tutorial/polls.yaml
    • Removed the # [START gke_kubernetes_deployment_python] and # [END gke_kubernetes_deployment_python] comments on lines 26 and 98 respectively. This removes the old region tag.

The author has indicated that lint tests passed, but the test suite (nox -s py-3.9) returned a 403 error. This should be investigated further.


A little haiku to lighten the mood:

Old code must now go,
Clean slate, a fresh start we see,
New code shines so bright.

Thanks,
Gemini

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: container Issues related to the Kubernetes Engine API API. labels Jan 9, 2025
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request removes the redundant region tag gke_kubernetes_deployment_python from the polls.yaml file. This addresses the issue described in the linked bug report and improves the clarity of the sample code. However, the test failure needs to be investigated and resolved before this PR can be merged.

Copy link

snippet-bot bot commented Jan 9, 2025

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@iennae iennae merged commit e86eb76 into GoogleCloudPlatform:main Jan 15, 2025
10 checks passed
@OremGLG OremGLG deleted the garciadiaz-migrate-region-step2-347826199 branch January 16, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: container Issues related to the Kubernetes Engine API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants