Skip to content

Conversation

eapl-gemugami
Copy link
Contributor

Description

Fixes Internal: b/389957560

Follow-up of #13054

Checklist

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request updates the README.md file in the ndb/redis_cache/ directory to reflect a current Python 3 sample. Specifically, it addresses internal issue b/389957560 and is a follow-up to #13054.

Here's a breakdown of the changes:

  • File Changed: appengine/standard/migration/ndb/redis_cache/README.md
  • Changes: The README was updated to remove instructions for deploying with Python 2.7. The deployment instructions now only refer to Python 3.8 and using app3.yaml.
    • Lines 23-31 (old) were replaced with lines 23-27 (new). The old instructions for Python 2.7 deployment were removed, and the Python 3.7 deployment instruction was updated to Python 3.8.

The author has indicated that all relevant checklists have been completed, including linting and adherence to the sample guidelines.


A little haiku to lighten the mood:

Code flows like a stream,
Fixes merge, a gentle hum,
Progress finds its way.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Jan 14, 2025
@eapl-gemugami eapl-gemugami added the snippet-bot:force-run Force snippet-bot runs its logic label Jan 14, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 14, 2025
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README update looks good. Removing the Python 2.7 instructions is the right move, and updating the Python 3 instructions is helpful. Specifying Python 3.8 is also a good idea, as that is the most common Python 3 runtime used in App Engine Standard.

@eapl-gemugami eapl-gemugami marked this pull request as ready for review January 14, 2025 19:27
@eapl-gemugami eapl-gemugami requested review from a team as code owners January 14, 2025 19:27
@eapl-gemugami eapl-gemugami merged commit a2b7664 into GoogleCloudPlatform:main Jan 14, 2025
10 of 11 checks passed
@eapl-gemugami eapl-gemugami deleted the paradalicea/docs/gae/update-readme-in-migration-ndb-redis-cache branch January 14, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants