Skip to content

Conversation

alixhami
Copy link
Contributor

Python version of authorized view tutorial

I'm open to ideas on phrasing region tags. My intent was to have sections to match up with the tutorial, but also have a region tag that encompassed the whole thing so I could show it at the end of the tutorial.

@alixhami alixhami requested a review from tswast June 21, 2018 18:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2018
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample and tests LGTM.

@@ -0,0 +1,108 @@
#!/usr/bin/env python

# Copyright 2018 Google Inc. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Per go/releasing/preparing Google LLC, drop the "all rights reserved."

@alixhami alixhami merged commit 79b2639 into GoogleCloudPlatform:master Jun 21, 2018
@alixhami alixhami deleted the bq-authorized-view branch June 21, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bigquery cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants