Skip to content

Make firestore get_check_exists method work as intended. #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2020
Merged

Make firestore get_check_exists method work as intended. #3408

merged 3 commits into from
Apr 15, 2020

Conversation

artemrys
Copy link
Contributor

Since this commit firestore's client get method is not raising google.cloud.exceptions.NotFound if there is no such document.

get_check_exists function is now working properly - needs to be updated. My proposal is exists method (works for me).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2020
@artemrys artemrys marked this pull request as ready for review April 15, 2020 06:07
@artemrys artemrys requested review from a team and BenWhitehead as code owners April 15, 2020 06:07
@BenWhitehead BenWhitehead added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@BenWhitehead BenWhitehead added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@BenWhitehead BenWhitehead added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 15, 2020
@BenWhitehead BenWhitehead added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 15, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9c8cd92 into GoogleCloudPlatform:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

+1 more reviewer

@tmatsuo tmatsuo tmatsuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crwilcox crwilcox

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@artemrys @tmatsuo @BenWhitehead @crwilcox @googlebot @kokoro-team