-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable Workload Identity Federation with Kubernetes and add docs #459
feat: enable Workload Identity Federation with Kubernetes and add docs #459
Conversation
(cherry picked from commit 52c4188)
@dargudear-google thank you for your attention regarding this enhancement. Please let me know if there is anything else I could do to help this along. Below is a bit more of an explanation of the change to help guide any review. This change really comes down to letting the secrets-store-csi-driver-provider-gcp/auth/auth.go Lines 276 to 284 in 4390d2d
secrets-store-csi-driver-provider-gcp/auth/auth.go Lines 120 to 133 in 4390d2d
The audience string This allows the provider to meet the expectation set forth by AIP-4117, External Account Credentials (Workload Identity Federation), which elaborates on how one should be determining the subject token in file sourced credentials and follows the conventions set forth by IAM Documentation regarding Configure Workload Identity Federation with Kubernetes. This also retains all the functionality established to meet the conventions laid out in the GKE Enterprise Fleet Management docs regarding how to Use fleet Workload Identity Federation in application. |
Is there anything I can help with? I understand the e2e won't run without creds for a PR. If there were two needs that could "magically" get addressed to help ship this, please let me know and I can work on them. |
910784e
into
GoogleCloudPlatform:main
Apologies for the delay due to release. |
Presently the provider is limited to only work with GKE or Fleet Workload Identity pool providers. This PR ensures that the gcp provider may retrieve secrets on a cluster utilizing GOOGLE_APPLICATION_CREDENTIALS pointing to an audience pool provider backed by Workload Identity Federation with Kubernetes.
Fixes: #206