Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Swivel sample and Matching Engine sample #193

Merged
merged 21 commits into from
Jan 13, 2022

Conversation

yinghsienwu
Copy link
Collaborator

If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under # Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

If you are opening a PR for Community Notebooks under the notebooks/community folder:

  • This notebook has been added to the CODEOWNERS file under the # Community Notebooks section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

If you are opening a PR for Community Content under the community-content folder:

  • Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
  • The main content directory has been added to the CODEOWNERS file under the # Community Content section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

@yinghsienwu yinghsienwu requested a review from a team as a code owner December 21, 2021 18:58
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@yinghsienwu
Copy link
Collaborator Author

Logs: https://pantheon.corp.google.com/cloud-build/builds/030841be-adef-4e87-b903-bf45c38bb70a?project=python-docs-samples-tests

Detected the following error in intro-swivel.ipynb:
Step #3: ContextualVersionConflict: (google-api-core 2.3.2 (/builder/home/.local/lib/python3.9/site-packages), Requirement.parse('google-api-core<2dev,>=1.21.0'), {'google-api-python-client'})

@yinghsienwu
Copy link
Collaborator Author

In summary, pinned KFP version caused the version conflict. The execution test passed when I used the Vertex SDK to submit a Vertex Pipeline job and did not specify the service account.

@@ -153,7 +153,7 @@
"source": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

network_name: my_network_name -> network_name: e.g., my_network_name


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close.

network_name: network_name: e.g -> network_name: e.g.,

Note you repeated network_name twice.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -153,7 +153,7 @@
"source": [
Copy link
Contributor

@andrewferlitsch andrewferlitsch Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused. Subtitle is about Tensorboard, but text refers to Vertex ML Metadata browser.


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I updated the description. Thanks!

@andrewferlitsch andrewferlitsch merged commit ee60889 into GoogleCloudPlatform:main Jan 13, 2022
diemtvu referenced this pull request in diemtvu/vertex-ai-samples Mar 4, 2022
* Update swivel and matchine engine samples

* Fix lint

* format notebooks

* fix lint

* fix lint

* upgrade google-python-api-client for testing pipeline

* upgrade google-api-core for testing pipeline

* install tensorflow after other required packages

* fix lint

* upgrade google-auth for testing

* install tensorflow in testing env

* upgrade pip with user flag

* remove kfp as a dependency

* separate matching engine notebook into another commit

* fix service account extraction

* service account is optional so comment it

* submit pipeline without specifying service account

* clarify how TensorBoard relates to Vertex ML metadata

* add reference to Vertex ML metadata

* fix typo

Co-authored-by: Andrew Ferlitsch <aferlitsch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants