-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Swivel sample and Matching Engine sample #193
Update Swivel sample and Matching Engine sample #193
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Detected the following error in intro-swivel.ipynb: |
In summary, pinned KFP version caused the version conflict. The execution test passed when I used the Vertex SDK to submit a Vertex Pipeline job and did not specify the service account. |
@@ -153,7 +153,7 @@ | |||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close.
network_name: network_name: e.g -> network_name: e.g.,
Note you repeated network_name twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -153,7 +153,7 @@ | |||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused. Subtitle is about Tensorboard, but text refers to Vertex ML Metadata browser.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I updated the description. Thanks!
* Update swivel and matchine engine samples * Fix lint * format notebooks * fix lint * fix lint * upgrade google-python-api-client for testing pipeline * upgrade google-api-core for testing pipeline * install tensorflow after other required packages * fix lint * upgrade google-auth for testing * install tensorflow in testing env * upgrade pip with user flag * remove kfp as a dependency * separate matching engine notebook into another commit * fix service account extraction * service account is optional so comment it * submit pipeline without specifying service account * clarify how TensorBoard relates to Vertex ML metadata * add reference to Vertex ML metadata * fix typo Co-authored-by: Andrew Ferlitsch <aferlitsch@google.com>
If you are opening a PR for
Official Notebooks
under the notebooks/official folder, follow this mandatory checklist:# Official Notebooks
section, pointing to the author or the author's team.If you are opening a PR for
Community Notebooks
under the notebooks/community folder:# Community Notebooks
section, pointing to the author or the author's team.If you are opening a PR for
Community Content
under the community-content folder:Content Directory Name
is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content# Community Content
section, pointing to the author or the author's team.