Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

DOC: use -p with mkdir ~/bin since might exist already #150

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

yarikoptic
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@yarikoptic
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@@ -28,7 +28,7 @@ curl -LO https://storage.googleapis.com/container-diff/latest/container-diff-lin
OR, if you want to avoid using sudo:

```shell
curl -LO https://storage.googleapis.com/container-diff/latest/container-diff-linux-amd64 && chmod +x container-diff-linux-amd64 && mkdir $HOME/bin && export PATH=$PATH:$HOME/bin && mv container-diff-linux-amd64 $HOME/bin/container-diff
curl -LO https://storage.googleapis.com/container-diff/latest/container-diff-linux-amd64 && chmod +x container-diff-linux-amd64 && mkdir -p $HOME/bin && export PATH=$PATH:$HOME/bin && mv container-diff-linux-amd64 $HOME/bin/container-diff
Copy link
Contributor

@r2d4 r2d4 Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM, but shouldn't we be downloading to /usr/local/bin or something other than $HOME/bin, which isn't standard? We can remove the $PATH modifying too, which won't work for new shells @nkubala

Copy link
Contributor Author

@yarikoptic yarikoptic Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a snippet for /usr/local/bin installation already (via sudo, since user might not have permissions to mess with it as well).
I am curious -- what did you mean by $PATH modifying ... won't work for new shells?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add export PATH=$PATH:$HOME/bin to your bashrc or a similar startup script, otherwise when you open a new shell, the path variable won't include your changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I just misread your statement, and by "new shells" meant really new types of shells etc, not just new shell sessions. Thanks for the explanation.
yeah -- in my case PATH already includes ~/bin ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is just a second option if users don't want to use sudo to copy to /usr/local/bin or another shared directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, didn't see that!

@r2d4 r2d4 merged commit 1b11c9b into GoogleContainerTools:master Nov 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants