This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Drop umask to 0 when writing files to disk #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
reviewed
Nov 29, 2017
pkg/util/tar_utils.go
Outdated
| // drop the umask temporarily to 0, so we can create all files with correct permissions | ||
| // otherwise the default (022) will cause file permission inconsistencies | ||
| oldMask := syscall.Umask(0) | ||
| defer syscall.Umask(oldMask) |
There was a problem hiding this comment.
Can you explicitly call os.Chmod instead of this? It should be more cross platform.
|
👍 for this change. I ran quite often into this issue. |
dlorenc
reviewed
Nov 30, 2017
pkg/util/tar_utils.go
Outdated
| @@ -80,6 +80,12 @@ func unpackTar(tr *tar.Reader, path string) error { | |||
| logrus.Errorf("Error opening file %s", target) | |||
| return err | |||
| } | |||
| // manually set permissions on file, since the default umask (022) will interfere | |||
| err = os.Chmod(target, mode) | |||
| if err != nil { | |||
There was a problem hiding this comment.
nit: inline the err/if statement here.
dlorenc
approved these changes
Nov 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, files were being written from an image to disk with incorrect permissions because of the default umask value (022). Temporarily dropping this to 0 allows the files to get written with their true permissions.