Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

added Labels to the ConfigObject #182

Merged
merged 3 commits into from
Jan 29, 2018

Conversation

datwiz
Copy link
Contributor

@datwiz datwiz commented Jan 28, 2018

Added Lables to the image ConfigObject.
Resolves Issue #181

@datwiz
Copy link
Contributor Author

datwiz commented Jan 28, 2018

Tests passing in my local build environment, but failing in TravisCI build. Working on isolating the cause.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry you had issues with Travis! Please link this PR in your container-structure-test PR for reference.

@nkubala nkubala merged commit 69025c1 into GoogleContainerTools:master Jan 29, 2018
@datwiz
Copy link
Contributor Author

datwiz commented Jan 29, 2018

Thanks, I think the addition is still causing a build failure and the green build status may have been a race between the green build where I removed my change and the red build when I added it back.
The thread I'm tracking down is whether there is a difference in json unmarshalling between the environment I'm using locally and the travis build environment.

@datwiz
Copy link
Contributor Author

datwiz commented Jan 29, 2018

Just re-ran a build from my github repo and looks like the build was successful this time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants