This repository was archived by the owner on Mar 27, 2024. It is now read-only.
only append latest tag to image once #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/util/image_utils.go
Outdated
|
|
||
| // checks to see if an image string contains a tag. | ||
| func HasTag(image string) bool { | ||
| tagRegex := regexp.MustCompile(".*:[^/]*$") |
There was a problem hiding this comment.
can you add some unit tests for the regex?
tejal29
previously approved these changes
Mar 14, 2018
cmd/root.go
Outdated
| @@ -135,28 +135,21 @@ func getPrepperForImage(image string) (pkgutil.Prepper, error) { | |||
| } | |||
|
|
|||
| // see if the image name has tag provided, if not add latest as tag | |||
| if !strings.Contains(image, ":") { | |||
| if !pkgutil.HasTag(image) { | |||
| image = image + ":latest" | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use regex to check if image has tag. Previously, we were just doing a simple
strings.Contains(image, ":"), which would give us a false positive when checking strings with theremote://ordaemon://prefixes. This should fix those cases.