Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Create default ImageSource if none is provided #205

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Create default ImageSource if none is provided #205

merged 1 commit into from
Mar 19, 2018

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Mar 19, 2018

This will allow callers to just pass in the Source when creating a Prepper struct, e.g.

prepper := &CloudPrepper{
  Source: "gcr.io/registry/image",
}

and avoid getting a panic when calling prepper.GetImage().

@nkubala nkubala requested review from priyawadhwa and dlorenc March 19, 2018 17:52
@nkubala nkubala merged commit 9ba9d88 into GoogleContainerTools:master Mar 19, 2018
@nkubala nkubala deleted the imgsrc_default branch March 19, 2018 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkubala @priyawadhwa