This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Correctly handle case where no image source is parsed #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
reviewed
Apr 2, 2018
| @@ -57,7 +57,9 @@ func (p *DaemonPrepper) GetFileSystem() (string, error) { | |||
| } | |||
|
|
|||
| src, err := ref.NewImageSource(nil) | |||
| defer src.Close() | |||
There was a problem hiding this comment.
I think you can get the same thing by skipping the if nil check and moving this to under the if err check.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a panic that happens most commonly when a docker ID is passed instead of an image path.