Refactor replica operations to a top-level type in the API #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryneeverett
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Looks good. The approach you've outlined in #372 seems quite promising and I look forward to it being proven in subsequent PRs.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of #372, and makes
Operation(formerlyReplicaOp) a top-level type that can be part of the TC API.ReplicaOp had a few methods related to
SyncOp, which is not a public type, so these were not useful in the public API. Those have been removed. However, thetaskchampion::storage::ReplicaOptype still exists (now as a type alias) to try to minimize changes to the API. I suspect #372 will be a breaking change, anyway, so this is probably superfluous.