replace set! with hashset::from #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with cargo fmt
djmitche
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
The patch looks good! Typically the PR description should say what it does without the context of the relevant issue, and the PR body should link to the issue (as you've done here).
As a quick tip, if you write "Fixes #415" then GitHub will automatically close the issue when the PR is merged.
|
Thanks! That was a good choice to practice making a PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope, I do the right. This is my very first contribution to an opensource project.
The issue is the following #415