Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clippy fail on warnings #429

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Make clippy fail on warnings #429

merged 2 commits into from
Jul 22, 2024

Conversation

djmitche
Copy link
Collaborator

As @ryneeverett noted on #428, as it stands clippy warnings aren't shown anywhere. This should "D"eny them. I've temporarily added an unused method to generate a warning.

djmitche
djmitche commented Jul 22, 2024
View reviewed changes
Copy link
Collaborator Author

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it worked.

taskchampion/src/replica.rs Outdated Show resolved Hide resolved
@djmitche djmitche requested a review from ryneeverett July 22, 2024 22:22
ryneeverett
ryneeverett approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@ryneeverett ryneeverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djmitche djmitche merged commit 009b091 into GothenburgBitFactory:main Jul 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryneeverett ryneeverett ryneeverett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djmitche @ryneeverett