[BREAKING] Update undo support to use Operations #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the existing "undo" support to use `Operations`, while making some additional changes to look forward to more general undo support (GothenburgBitFactory#427 being the next step on that journey). Breaking changes: - `Replica::get_undo_ops` is now `Replica::get_undo_operations` and returns an `Operations` value. It now returns the operations in the order they were applied, and includes the undo point operation, if one exists. - `Replica::commit_undo_ops` is now `Replica::commit_reversed_operations` and takes an `Operations` value. It now expects an `Operations` value as provided by `get_undo_operations`.
ryneeverett
approved these changes
Jul 29, 2024
|
Yes. The idea is to make commit_reversed_operations a little more generic by not assuming it is reversing to an undo point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the existing "undo" support to use
Operations, while making some additional changes to look forward to more general undo support (#427 being the next step on that journey).Breaking changes:
Replica::get_undo_opsis nowReplica::get_undo_operationsand returns anOperationsvalue. It now returns the operations in the order they were applied, and includes the undo point operation, if one exists.Replica::commit_undo_opsis nowReplica::commit_reversed_operationsand takes anOperationsvalue as provided byget_undo_operations.This is the second of the two planned breaking changes in #372.