Use Vec<Operation> instead of newtype Operations
#443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing the full functionality of a Vec here is more useful than utility functions on a newtype, especially when building a Cxx bridge. This is a big diff, but aside from the main change in `operation.rs`, consists almost entirely of changing `ops.add` to `ops.push`, with a few related test changes.
ryneeverett
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
You know, I almost suggested this when reviewing Operations the first time -- it seemed like an extra abstraction which wasn't "buying" us much over a Vec. But it wasn't a terribly expensive abstraction so I figured I'd let you have it -- but I guess cxx isnt' so generous. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing the full functionality of a Vec here is more useful than utility functions on a newtype, especially when building a Cxx bridge.
This is a big diff, but aside from the main change in
operation.rs, consists almost entirely of changingops.addtoops.push, with a few related test changes.This will be the last change for #372, and without objection I will release 0.7.0 when this is merged.