Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.1.0] Make symbol::set_string take a std::string_view instead of a const std::string& #32

Closed
lmichaelis opened this issue Nov 6, 2022 · 0 comments
Closed

[v1.1.0] Make symbol::set_string take a std::string_view instead of a const std::string& #32

lmichaelis opened this issue Nov 6, 2022 · 0 comments
Assignees
@lmichaelis
Labels
performance
Milestone
v1.1.0

Comments

@lmichaelis
Copy link
Member

This makes sense because the string is copied internally anyways. Additionally, defaulting to taking std::string_view provides more opportunities for copy elision. This is needed as a consequence to #30.
@lmichaelis lmichaelis added this to the v1.1.0 milestone Nov 6, 2022
@lmichaelis lmichaelis self-assigned this Dec 19, 2022
lmichaelis added a commit that referenced this issue Dec 19, 2022
@lmichaelis
[#32] script: make symbol::get_string return std::string_view
569c8ea 
This should optimize some redundant string copies and provides
the ability to return `std::string_view`s from VM external
functions. This will also enable further optimization in
the future.
@lmichaelis lmichaelis added awaiting verification The problem has been fixed, though external verification of this fix is required and removed good first issue Good for newcomers labels Dec 19, 2022
lmichaelis added a commit that referenced this issue Dec 26, 2022
@lmichaelis
[#32] script: make symbol::get_string return std::string_view
0bfd3cf 
This should optimize some redundant string copies and provides
the ability to return `std::string_view`s from VM external
functions. This will also enable further optimization in
the future.
@lmichaelis lmichaelis removed the awaiting verification The problem has been fixed, though external verification of this fix is required label Dec 26, 2022
DaDummy pushed a commit to DaDummy/phoenix that referenced this issue Dec 26, 2022
@lmichaelis @DaDummy
[GothicKit#32] script: make symbol::get_string return `std::string_…
91c7bd7 
…view`

This should optimize some redundant string copies and provides
the ability to return `std::string_view`s from VM external
functions. This will also enable further optimization in
the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmichaelis lmichaelis

Labels
performance
Projects
None yet
Milestone
v1.1.0
Development

When branches are created from issues, their pull requests are automatically linked.

tweak/set-string-view GothicKit/ZenKit
1 participant
@lmichaelis