Add task accessors and check more task properties #1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation-plugin # Conflicts: # src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/JavaPluginsTest.kt
Goooler
force-pushed
the
g/20250920/test-application-plugin
branch
from
2f99c52 to
45c27db
Compare
Goooler
force-pushed
the
g/20250920/test-application-plugin
branch
from
45c27db to
49b9011
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the Shadow plugin's test coverage and public API by adding more task accessors and comprehensive property validation. The changes improve testing robustness by verifying task properties and dependencies more thoroughly, while also expanding the plugin's public API with additional convenience accessors.
- Add comprehensive property validation for shadow tasks in application plugin scenarios
- Introduce new task accessors for better developer experience with the Shadow plugin API
- Improve test reliability by using proper task dependency checking methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPropertiesTest.kt | Enhanced test coverage with new application plugin test and improved property validation |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt | Added new task and distribution accessors for improved API usability |
| docs/changes/README.md | Updated changelog to document the new task accessors feature |
| api/shadow.api | Updated API dump to reflect new public accessors |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.