Cplusplus #13
Closed
Cplusplus #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtfbbqhax
force-pushed
the
cplusplus
branch
2 times, most recently
from
594994f
to
79f030b
Compare
Client and Server are fully converted to C++
SDL implementation was converted, requiring additional changes to
build Renderercommon
BGame code was modified to prevent name clashes with builtin name
"class" in C++. (These parts of BGame should be broken away from
the server code).
Some files under qcommon can not be converted due to shared usage
with game logic (e.g., q_shared.c)
apparently WIN32 doesn't work when compiling as C++. Must use
_WIN32.
There seems to be alot of cases of mixed WIN32, _WIN32 and __WIN32__
and should be fixed.
Given an array b[] of length n, pointers to &b[0]..&b[n] are defined (where only &b[0]..&b[n-1] can be validly dereferenced). &b[-1], or equivalently b-1, is not something we can use in valid Standard C. gcc 6 diagnoses this as: code/client/snd_wavelet.c:33:9: warning: array subscript is below array bounds [-Warray-bounds] and might take this undefined behaviour as permission to emit "more efficient" object code that is not what the author expected, for example nothing at all. Use a macro to fake a 1-based array instead.
Modernize struct declarations
Use `bool` as datatype instead of `qboolean`
bg_public.h is no longer a dependency for the server
Cleaned up client.h
Replace many instances of qboolean with bool
Key bindings lua interface
Cmd execute interface
Added example lua binds configuration
Prefer pure memset/memcpy vs Com_Memset/Com_Memcpy
Remove unused file module.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change converts the core engine to C++.
Additional work adds Lua interfaces to key bindings
Additional bug fixes ported from ioq3