Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make format #21

Merged
merged 1 commit into from Oct 29, 2019
Merged

Make format #21

merged 1 commit into from Oct 29, 2019

Conversation

znicholls
Copy link
Collaborator

First tweak I'd make to #20, run make format to auto-format the code

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #21 into RL-cleanup will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           RL-cleanup      #21   +/-   ##
===========================================
  Coverage       99.05%   99.05%           
===========================================
  Files              10       10           
  Lines             318      318           
  Branches           54       54           
===========================================
  Hits              315      315           
  Misses              1        1           
  Partials            2        2
Impacted Files Coverage Δ
src/silicone/stats_utils.py 100% <ø> (ø) ⬆️
...one/database_crunchers/quantile_rolling_windows.py 100% <100%> (ø) ⬆️
src/silicone/plotting.py 95.23% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b7e74...eb6b0b4. Read the comment docs.

This was referenced Oct 29, 2019
Copy link
Collaborator

@Rlamboll Rlamboll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly, some of these look pretty ugly to me - do we have to do things like
derived_relationships[
db_time
] = lambda unused_variable, ys=ys, cumsum_weights=cumsum_weights, quantile=quantile: min(
ys[cumsum_weights >= quantile]
)

Is there any way to make it ok with slightly longer lines?

@znicholls
Copy link
Collaborator Author

Ye somewhere in the docs we can https://black.readthedocs.io/en/stable/the_black_code_style.html#line-length

I’ve found that it looks better over time as you get used to the consistency although it is definitely tough to start

@Rlamboll Rlamboll merged commit ea0ac10 into RL-cleanup Oct 29, 2019
@Rlamboll Rlamboll deleted the RL-cleanup-format branch October 29, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants